Add TencentES client #623
Conversation
alwayslove2013
left a comment
alwayslove2013
left a comment
There was a problem hiding this comment.
Awesome work on this pull request! We really appreciate your contribution to the community!
| SECONDS_WAITING_FOR_FORCE_MERGE_API_CALL_SEC = 30 | ||
|
|
||
|
|
||
| class TencentElasticsearch(VectorDB): |
There was a problem hiding this comment.
I've noticed that the code here is very similar to the one for ElasticCloud. You can try to directly inherit from the ElasticCloud class and override any operations that are different. For specific practices, you can refer to
| ) | ||
|
|
||
|
|
||
| class TencentElasticsearchTypedDict(CommonTypedDict): |
There was a problem hiding this comment.
It would be great if this CLI tool could support ElasticCloud, AliyunES, and TencentES. Otherwise, no rush—I can handle it in a follow-up PR.
There was a problem hiding this comment.
I have made the TencentElasticsearch client class directly inherit from the ElasticCloud class.
Sorry, I haven't made changes to the CLI tool because I don't have test resources for ElasticCloud or AliyunES, and I'm unsure if the modifications will work properly. Could you merge my PR first, and then merge the CLI tool changes later?
|
@alwayslove2013 When you have time, please help me review the latest commit. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alwayslove2013, morning-color The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
4 participants
Tencent ES is not merely a vector database; it offers a more comprehensive one-stop AI search solution, surpassing the scope of single-point solutions provided by traditional vector databases. Its capabilities include but are not limited to document parsing, text chunking, embedding, model reranking, and LLM integration.
Welcome to experience: https://cloud.tencent.com/product/es .